]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - fs/ceph/file.c
ceph: fix splice read for no Fc capability case
authorYan, Zheng <zyan@redhat.com>
Tue, 8 Nov 2016 13:54:34 +0000 (21:54 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 12 Dec 2016 22:54:27 +0000 (23:54 +0100)
commit7ce469a53e7106acdaca2e25027941d0f7c12a8e
tree81864fb541f3ba5eb6080823d961addc87053955
parent2b1ac852eb67a6e95595e576371d23519105559f
ceph: fix splice read for no Fc capability case

When iov_iter type is ITER_PIPE, copy_page_to_iter() increases
the page's reference and add the page to a pipe_buffer. It also
set the pipe_buffer's ops to page_cache_pipe_buf_ops. The comfirm
callback in page_cache_pipe_buf_ops expects the page is from page
cache and uptodate, otherwise it return error.

For ceph_sync_read() case, pages are not from page cache. So we
can't call copy_page_to_iter() when iov_iter type is ITER_PIPE.
The fix is using iov_iter_get_pages_alloc() to allocate pages
for the pipe. (the code is similar to default_file_splice_read)

Signed-off-by: Yan, Zheng <zyan@redhat.com>
fs/ceph/file.c