]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - net/ipv4/inet_connection_sock.c
inet: fix improper empty comparison
authorJosef Bacik <jbacik@fb.com>
Sat, 23 Sep 2017 00:20:08 +0000 (20:20 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sat, 23 Sep 2017 03:33:17 +0000 (20:33 -0700)
commitfbed24bcc69d3e48c5402c371f19f5c7688871e5
treed7ff42f5bdbdf81bdbdb2efa92674afcbf88fc4b
parent7a56673b58f2414679e926bba80309a037a4fd35
inet: fix improper empty comparison

When doing my reuseport rework I screwed up and changed a

if (hlist_empty(&tb->owners))

to

if (!hlist_empty(&tb->owners))

This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind conflict if we
opened an ipv4 only socket on a port followed by an ipv6 only socket on
the same port.

Fixes: b9470c27607b ("inet: kill smallest_size and smallest_port")
Reported-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_connection_sock.c