]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
block: blk_init_allocated_queue() set q->fq as NULL in the fail case
authorxiao jin <jin.xiao@intel.com>
Mon, 30 Jul 2018 06:11:12 +0000 (14:11 +0800)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:45:32 +0000 (19:45 -0600)
commit001b077d3a4687d17cfefbccd0daad4be2c6ac86
tree481d9f1f008ea994b874db7aa06049a45f926865
parent8c0c5d4efef0a36c575140395180cc123581ca38
block: blk_init_allocated_queue() set q->fq as NULL in the fail case

BugLink: https://bugs.launchpad.net/bugs/1835972
commit 54648cf1ec2d7f4b6a71767799c45676a138ca24 upstream.

We find the memory use-after-free issue in __blk_drain_queue()
on the kernel 4.14. After read the latest kernel 4.18-rc6 we
think it has the same problem.

Memory is allocated for q->fq in the blk_init_allocated_queue().
If the elevator init function called with error return, it will
run into the fail case to free the q->fq.

Then the __blk_drain_queue() uses the same memory after the free
of the q->fq, it will lead to the unpredictable event.

The patch is to set q->fq as NULL in the fail case of
blk_init_allocated_queue().

Fixes: commit 7c94e1c157a2 ("block: introduce blk_flush_queue to drive flush machinery")
Cc: <stable@vger.kernel.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: xiao jin <jin.xiao@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
block/blk-core.c