]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: stkwebcam: fix runtime PM after driver unbind
authorJohan Hovold <johan@kernel.org>
Tue, 1 Oct 2019 08:49:08 +0000 (10:49 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:38 +0000 (19:04 +0100)
commit04107fce2409aabeb3998bbdc46cb154f929022e
tree7cda5ebf710aa7850f4494f583edeb44a2a2d1ab
parentc3031c8b0ef51b907ec64e488acb9ea780bdbb0d
media: stkwebcam: fix runtime PM after driver unbind

BugLink: https://bugs.launchpad.net/bugs/1850541
commit 30045f2174aab7fb4db7a9cf902d0aa6c75856a7 upstream.

Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate
interface PM usage counter") USB drivers must always balance their
runtime PM gets and puts, including when the driver has already been
unbound from the interface.

Leaving the interface with a positive PM usage counter would prevent a
later bound driver from suspending the device.

Note that runtime PM has never actually been enabled for this driver
since the support_autosuspend flag in its usb_driver struct is not set.

Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter")
Cc: stable <stable@vger.kernel.org>
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191001084908.2003-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/media/usb/stkwebcam/stk-webcam.c