]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: adutux: fix use-after-free on release
authorJohan Hovold <johan@kernel.org>
Wed, 9 Oct 2019 15:38:44 +0000 (17:38 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:32 +0000 (19:04 +0100)
commit0977f356b1fe3d67ac279cfebc920d7f969b1e2e
treea773df16041647bacd17c46d7da0eeb4ed1fd5dd
parent04be63a6f923dbe695eeb3aecb61fb3d15fcc332
USB: adutux: fix use-after-free on release

BugLink: https://bugs.launchpad.net/bugs/1850541
commit 123a0f125fa3d2104043697baa62899d9e549272 upstream.

The driver was accessing its struct usb_device in its release()
callback without holding a reference. This would lead to a
use-after-free whenever the device was disconnected while the character
device was still open.

Fixes: 66d4bc30d128 ("USB: adutux: remove custom debug macro")
Cc: stable <stable@vger.kernel.org> # 3.12
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009153848.8664-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/misc/adutux.c