]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
dmaengine: cppi41: delete channel from pending list when stop channel
authorBin Liu <b-liu@ti.com>
Mon, 12 Nov 2018 15:43:22 +0000 (09:43 -0600)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:45:04 +0000 (09:45 -0600)
commit0a8d77b6c0ced4250f486e8845ff4454bd73dee0
tree6bc954e63dd92555316bb486efe4d8234aaf22b1
parent584293c91e57f1b95dc70a7df7698c0e8d9df234
dmaengine: cppi41: delete channel from pending list when stop channel

BugLink: https://bugs.launchpad.net/bugs/1837161
commit 59861547ec9a9736e7882f6fb0c096a720ff811a upstream.

The driver defines three states for a cppi channel.
- idle: .chan_busy == 0 && not in .pending list
- pending: .chan_busy == 0 && in .pending list
- busy: .chan_busy == 1 && not in .pending list

There are cases in which the cppi channel could be in the pending state
when cppi41_dma_issue_pending() is called after cppi41_runtime_suspend()
is called.

cppi41_stop_chan() has a bug for these cases to set channels to idle state.
It only checks the .chan_busy flag, but not the .pending list, then later
when cppi41_runtime_resume() is called the channels in .pending list will
be transitioned to busy state.

Removing channels from the .pending list solves the problem.

Fixes: 975faaeb9985 ("dma: cppi41: start tear down only if channel is busy")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Bin Liu <b-liu@ti.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/dma/cppi41.c