]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
vmw_balloon: fix VMCI use when balloon built into kernel
authorNadav Amit <namit@vmware.com>
Tue, 19 Jun 2018 23:00:27 +0000 (16:00 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:45:47 +0000 (19:45 -0600)
commit0f09376559e5488c23b21a944898b68e99f22b58
treeca700ae236ab6eda697a345786c82262be8bd85e
parent04b9e943f976c1c2a129896b409454034f2d42f1
vmw_balloon: fix VMCI use when balloon built into kernel

BugLink: https://bugs.launchpad.net/bugs/1835972
commit c3cc1b0fc27508da53fe955a3b23d03964410682 upstream.

Currently, when all modules, including VMCI and VMware balloon are built
into the kernel, the initialization of the balloon happens before the
VMCI is probed. As a result, the balloon fails to initialize the VMCI
doorbell, which it uses to get asynchronous requests for balloon size
changes.

The problem can be seen in the logs, in the form of the following
message:
"vmw_balloon: failed to initialize vmci doorbell"

The driver would work correctly but slightly less efficiently, probing
for requests periodically. This patch changes the balloon to be
initialized using late_initcall() instead of module_init() to address
this issue. It does not address a situation in which VMCI is built as a
module and the balloon is built into the kernel.

Fixes: 48e3d668b790 ("VMware balloon: Enable notification via VMCI")
Cc: stable@vger.kernel.org
Reviewed-by: Xavier Deguillard <xdeguillard@vmware.com>
Signed-off-by: Nadav Amit <namit@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/misc/vmw_balloon.c