]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
smack: use GFP_NOFS while holding inode_smack::smk_lock
authorEric Biggers <ebiggers@google.com>
Thu, 22 Aug 2019 05:54:41 +0000 (22:54 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 16 Oct 2019 09:55:47 +0000 (11:55 +0200)
commit0f50006f85b3f7216030f4e3a449f79934f49eae
treeed598e31088580626cca463e625081dea147e01e
parenta246e075da8bdd385765fbda7cee636c17650abe
smack: use GFP_NOFS while holding inode_smack::smk_lock

BugLink: https://bugs.launchpad.net/bugs/1848274
commit e5bfad3d7acc5702f32aafeb388362994f4d7bd0 upstream.

inode_smack::smk_lock is taken during smack_d_instantiate(), which is
called during a filesystem transaction when creating a file on ext4.
Therefore to avoid a deadlock, all code that takes this lock must use
GFP_NOFS, to prevent memory reclaim from waiting for the filesystem
transaction to complete.

Reported-by: syzbot+0eefc1e06a77d327a056@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
security/smack/smack_access.c
security/smack/smack_lsm.c