]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
blk-mq: I/O and timer unplugs are inverted in blktrace
authorIlya Dryomov <idryomov@gmail.com>
Wed, 26 Sep 2018 12:35:50 +0000 (14:35 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:52:51 +0000 (19:52 -0600)
commit0f7cb0dbc87929e34e14028c076b0a89de6348e5
tree2e866e7148166f76f8859411d595923bd07e118b
parent0e4e6e7f463888b26e015b4c06a46e24556ea3c4
blk-mq: I/O and timer unplugs are inverted in blktrace

BugLink: https://bugs.launchpad.net/bugs/1836426
commit 587562d0c7cd6861f4f90a2eb811cccb1a376f5f upstream.

trace_block_unplug() takes true for explicit unplugs and false for
implicit unplugs.  schedule() unplugs are implicit and should be
reported as timer unplugs.  While correct in the legacy code, this has
been inverted in blk-mq since 4.11.

Cc: stable@vger.kernel.org
Fixes: bd166ef183c2 ("blk-mq-sched: add framework for MQ capable IO schedulers")
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
block/blk-mq.c