]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
macvtap: fix use after free for skb_array during release
authorJason Wang <jasowang@redhat.com>
Thu, 11 Aug 2016 10:15:56 +0000 (18:15 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Aug 2016 16:55:51 +0000 (09:55 -0700)
commit104a493390940e85fb7c840a9fd5214aba5cb3bd
treed3852c2c9aafedd2debb4ea48f32c9c65fe034a6
parent4b5b9ba553f9aa5f484ab972fc9b58061885ceca
macvtap: fix use after free for skb_array during release

We've clean skb_array in macvtap_put_queue() but still try to pop from
it during macvtap_sock_destruct(). Fix this use after free by moving
the skb array cleanup to macvtap_sock_destruct() instead.

Fixes: 362899b8725b ("macvtap: switch to use skb array")
Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvtap.c