]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
staging: comedi: ni_660x: fix missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 12 Feb 2019 18:44:50 +0000 (12:44 -0600)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit116c4ee825cb46adcad685bb70d002f566b90c54
tree8883ceb9550838341f0f077d54267e69b4157350
parentddea023fddec759452863773545f6bbc4745ea39
staging: comedi: ni_660x: fix missing break in switch statement

BugLink: https://bugs.launchpad.net/bugs/1837813
commit 479826cc86118e0d87e5cefb3df5b748e0480924 upstream.

Add missing break statement in order to prevent the code from falling
through to the default case and return -EINVAL every time.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/staging/comedi/drivers/ni_660x.c