]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
nfsd4: fix up replay_matches_cache()
authorScott Mayhew <smayhew@redhat.com>
Wed, 9 Oct 2019 19:11:37 +0000 (15:11 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:47:27 +0000 (23:47 -0500)
commit11eba56548bd580f10047585459cb278ddce12dd
treeff7e46305912633be8f113bbf006b5935695d730
parentece6ddead6097e3fcc774c87208761267d990189
nfsd4: fix up replay_matches_cache()

BugLink: https://bugs.launchpad.net/bugs/1860602
commit 6e73e92b155c868ff7fce9d108839668caf1d9be upstream.

When running an nfs stress test, I see quite a few cached replies that
don't match up with the actual request.  The first comment in
replay_matches_cache() makes sense, but the code doesn't seem to
match... fix it.

This isn't exactly a bugfix, as the server isn't required to catch every
case of a false retry.  So, we may as well do this, but if this is
fixing a problem then that suggests there's a client bug.

Fixes: 53da6a53e1d4 ("nfsd4: catch some false session retries")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/nfsd/nfs4state.c