]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: af_alg - wait for data at beginning of recvmsg
authorStephan Mueller <smueller@chronox.de>
Wed, 29 Nov 2017 11:02:23 +0000 (12:02 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 11 Dec 2017 11:29:54 +0000 (22:29 +1100)
commit11edb555966ed2c66c533d17c604f9d7e580a829
treedae6e140f8c759c9d966e7cb0e25b5c69f0dae7b
parent2b4f27c36bcd46e820ddb9a8e6fe6a63fa4250b8
crypto: af_alg - wait for data at beginning of recvmsg

The wait for data is a non-atomic operation that can sleep and therefore
potentially release the socket lock. The release of the socket lock
allows another thread to modify the context data structure. The waiting
operation for new data therefore must be called at the beginning of
recvmsg. This prevents a race condition where checks of the members of
the context data structure are performed by recvmsg while there is a
potential for modification of these values.

Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")
Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/af_alg.c
crypto/algif_aead.c
crypto/algif_skcipher.c