]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 7 Mar 2019 22:56:51 +0000 (15:56 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit15e56099dd9b2629fc9b3c796582a662a1e3081d
tree622f1c750f6c970d6e2f6cbeddd3b3ad962bf4f7
parent90d8cdee51c94764f2f1bb581e000ab4c3a273ef
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher

BugLink: https://bugs.launchpad.net/bugs/1838824
[ Upstream commit 89e28da82836530f1ac7a3a32fecc31f22d79b3e ]

When building with -Wsometimes-uninitialized, Clang warns:

drivers/soc/mediatek/mtk-pmic-wrap.c:1358:6: error: variable 'rdata' is
used uninitialized whenever '||' condition is true
[-Werror,-Wsometimes-uninitialized]

If pwrap_write returns non-zero, pwrap_read will not be called to
initialize rdata, meaning that we will use some random uninitialized
stack value in our print statement. Zero initialize rdata in case this
happens.

Link: https://github.com/ClangBuiltLinux/linux/issues/401
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/soc/mediatek/mtk-pmic-wrap.c