]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: i2c: adv748x: Fix unsafe macros
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 22 Oct 2019 13:25:22 +0000 (15:25 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 13 Mar 2020 04:31:00 +0000 (00:31 -0400)
commit19c7306f9f5e79db97c5ac2b1d16f4089f8332a0
tree6660f0d639279c4082331052a818811f5f6f65fc
parent8e69d4a864fa6ff55e0fece5e477886621375303
media: i2c: adv748x: Fix unsafe macros

BugLink: https://bugs.launchpad.net/bugs/1866678
commit 0d962e061abcf1b9105f88fb850158b5887fbca3 upstream.

Enclose multiple macro parameters in parentheses in order to
make such macros safer and fix the Clang warning below:

drivers/media/i2c/adv748x/adv748x-afe.c:452:12: warning: operator '?:'
has lower precedence than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]

ret = sdp_clrset(state, ADV748X_SDP_FRP, ADV748X_SDP_FRP_MASK, enable
? ctrl->val - 1 : 0);

Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/media/i2c/adv748x/adv748x.h