]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
lib/ubsan.c: don't mark __ubsan_handle_builtin_unreachable as noreturn
authorArnd Bergmann <arnd@arndb.de>
Fri, 16 Nov 2018 23:08:35 +0000 (15:08 -0800)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:59:21 +0000 (19:59 -0600)
commit1c3d82fd71e500afdfa990a0d9811712a87d9d2b
treedebf80f776378c07b9bc663f759444ab66df2951
parente1914d8c828b7464a8ffbb294ab2ee89a07ccbc3
lib/ubsan.c: don't mark __ubsan_handle_builtin_unreachable as noreturn

BugLink: https://bugs.launchpad.net/bugs/1836802
commit 1c23b4108d716cc848b38532063a8aca4f86add8 upstream.

gcc-8 complains about the prototype for this function:

  lib/ubsan.c:432:1: error: ignoring attribute 'noreturn' in declaration of a built-in function '__ubsan_handle_builtin_unreachable' because it conflicts with attribute 'const' [-Werror=attributes]

This is actually a GCC's bug. In GCC internals
__ubsan_handle_builtin_unreachable() declared with both 'noreturn' and
'const' attributes instead of only 'noreturn':

   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84210

Workaround this by removing the noreturn attribute.

[aryabinin: add information about GCC bug in changelog]
Link: http://lkml.kernel.org/r/20181107144516.4587-1-aryabinin@virtuozzo.com
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Acked-by: Olof Johansson <olof@lixom.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
lib/ubsan.c