]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: img-hash - remove unnecessary static in img_hash_remove()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 18 Jul 2017 23:07:12 +0000 (18:07 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 3 Aug 2017 05:47:18 +0000 (13:47 +0800)
commit1ce5b2f348c0e016d6195ffb974f7fb98785c90a
treeb9965d207decc5d9aeea42b6045bb609646400c2
parent47f1241ec320302edb77d117302b1990178b449b
crypto: img-hash - remove unnecessary static in img_hash_remove()

Remove unnecessary static on local variable hdev. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   text    data     bss     dec     hex filename
  14842    6464     128   21434    53ba drivers/crypto/img-hash.o

after:
   text    data     bss     dec     hex filename
  14789    6376      64   21229    52ed drivers/crypto/img-hash.o

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/img-hash.c