]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 1 Nov 2017 21:05:39 +0000 (17:05 -0400)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 22 Feb 2018 14:18:49 +0000 (08:18 -0600)
commit1d1b08072135d29ddd12c6e7d3adf1da7ccd29df
treedbe8b70e9b5d33d23a8d07a1ddabc5d39b586da9
parent9aa5a93e3f3c9715f834c992790cab63f371a797
media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code

BugLink: http://bugs.launchpad.net/bugs/1751064
commit a9cb97c3e628902e37583d8a40bb28cf76522cf1 upstream.

As smatch warned:
drivers/media/dvb-core/dvb_frontend.c:2468 dvb_frontend_handle_ioctl() error: uninitialized symbol 'err'.

The ioctl handler actually got a regression here: before changeset
d73dcf0cdb95 ("media: dvb_frontend: cleanup ioctl handling logic"),
the code used to return -EOPNOTSUPP if an ioctl handler was not
implemented on a driver. After the change, it may return a random
value.

Fixes: d73dcf0cdb95 ("media: dvb_frontend: cleanup ioctl handling logic")
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Tested-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/media/dvb-core/dvb_frontend.c