]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: axienet: fix a signedness bug in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 25 Sep 2019 10:59:11 +0000 (13:59 +0300)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit213f4864f2007df4b4878fda09ce9d46c2a12b25
tree7d1582e62c05955c67854a146aeb62a0ffb8c361
parent3d1cc58037abb3e8b606ba88e41aa21923a6ccde
net: axienet: fix a signedness bug in probe

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 73e211e11be86715d66bd3c9d38b3c34b05fca9a ]

The "lp->phy_mode" is an enum but in this context GCC treats it as an
unsigned int so the error handling is never triggered.

Fixes: ee06b1728b95 ("net: axienet: add support for standard phy-mode binding")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c