]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
tty: serial: pch_uart: correct usage of dma_unmap_sg
authorPeng Fan <peng.fan@nxp.com>
Wed, 13 Nov 2019 05:37:42 +0000 (05:37 +0000)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit2689ad926b78e86b18de8eb4252fd5fb51ad8e1e
tree030e244728a2ccc124452068976289a7dad22bf0
parentb80ea2445f52776f91b2414164aeaa69abb6a1d5
tty: serial: pch_uart: correct usage of dma_unmap_sg

BugLink: https://bugs.launchpad.net/bugs/1861934
commit 74887542fdcc92ad06a48c0cca17cdf09fc8aa00 upstream.

Per Documentation/DMA-API-HOWTO.txt,
To unmap a scatterlist, just call:
dma_unmap_sg(dev, sglist, nents, direction);

.. note::

The 'nents' argument to the dma_unmap_sg call must be
the _same_ one you passed into the dma_map_sg call,
it should _NOT_ be the 'count' value _returned_ from the
dma_map_sg call.

However in the driver, priv->nent is directly assigned with value
returned from dma_map_sg, and dma_unmap_sg use priv->nent for unmap,
this breaks the API usage.

So introduce a new entry orig_nent to remember 'nents'.

Fixes: da3564ee027e ("pch_uart: add multi-scatter processing")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/1573623259-6339-1-git-send-email-peng.fan@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/tty/serial/pch_uart.c