]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: serial: quatech2: handle unbound ports
authorJohan Hovold <johan@kernel.org>
Fri, 17 Jan 2020 14:35:26 +0000 (15:35 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit270beec585b373124bebe7bac737cd73fe948927
tree5108b796b39e28de999c3d64aad3bf989f38b945
parent8e3c8e8d4098f5c6fc48bef7943afedd87dd612c
USB: serial: quatech2: handle unbound ports

BugLink: https://bugs.launchpad.net/bugs/1862259
commit 9715a43eea77e42678a1002623f2d9a78f5b81a1 upstream.

Check for NULL port data in the modem- and line-status handlers to avoid
dereferencing a NULL pointer in the unlikely case where a port device
isn't bound to a driver (e.g. after an allocation failure on port
probe).

Note that the other (stubbed) event handlers qt2_process_xmit_empty()
and qt2_process_flush() would need similar sanity checks in case they
are ever implemented.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable <stable@vger.kernel.org> # 3.5
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/usb/serial/quatech2.c