]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
Input: sur40 - fix interface sanity checks
authorJohan Hovold <johan@kernel.org>
Fri, 10 Jan 2020 20:01:27 +0000 (12:01 -0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 6 Mar 2020 07:13:20 +0000 (02:13 -0500)
commit28e5927f18af0d33694ef7f9eb827b555a28b7e9
tree5a4a35426334736d7f90fd59fc39a0e14d178cce
parent6b7e95d3174180da43b87648b27f04f681909674
Input: sur40 - fix interface sanity checks

BugLink: https://bugs.launchpad.net/bugs/1864261
commit 6b32391ed675827f8425a414abbc6fbd54ea54fe upstream.

Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

This in turn could cause the driver to misbehave or trigger a WARN() in
usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Vladis Dronov <vdronov@redhat.com>
Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/input/touchscreen/sur40.c