]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ASoC: qcom: Fix of-node refcount unbalance in apq8016_sbc_parse_of()
authorTakashi Iwai <tiwai@suse.de>
Tue, 19 Feb 2019 15:46:50 +0000 (16:46 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit2b83ed338abb5c9b2b1ee48fd92b3df10d6ea310
tree6bff7f2595f51dfd5e1fe67c45a1134e8193c8c3
parent526a21d0d4e9bc0d60f98c9bd425707bdfdc71ed
ASoC: qcom: Fix of-node refcount unbalance in apq8016_sbc_parse_of()

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 8d1667200850f8753c0265fa4bd25c9a6e5f94ce ]

The apq8016 driver leaves the of-node refcount at aborting from the
loop of for_each_child_of_node() in the error path.  Not only the
iterator node of for_each_child_of_node(), the children nodes referred
from it for codec and cpu have to be properly unreferenced.

Fixes: bdb052e81f62 ("ASoC: qcom: add apq8016 sound card support")
Cc: Patrick Lai <plai@codeaurora.org>
Cc: Banajit Goswami <bgoswami@codeaurora.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/soc/qcom/apq8016_sbc.c