]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ASoC: rt5677: Mark reg RT5677_PWR_ANLG2 as volatile
authorBen Zhang <benzh@chromium.org>
Wed, 6 Nov 2019 01:13:30 +0000 (17:13 -0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:45:21 +0000 (23:45 -0500)
commit302a043f23a07d52ba160fcc31dd190d717139e4
tree38f15b2b6fc695216d3d62f10535e48cc9f1aef4
parenta8f506a0fe0bbe5595e1b747aa93c0101250b38a
ASoC: rt5677: Mark reg RT5677_PWR_ANLG2 as volatile

BugLink: https://bugs.launchpad.net/bugs/1859712
[ Upstream commit eabf424f7b60246c76dcb0ea6f1e83ef9abbeaa6 ]

The codec dies when RT5677_PWR_ANLG2(MX-64h) is set to 0xACE1
while it's streaming audio over SPI. The DSP firmware turns
on PLL2 (MX-64 bit 8) when SPI streaming starts.  However regmap
does not believe that register can change by itself. When
BST1 (bit 15) is turned on with regmap_update_bits(), it doesn't
read the register first before write, so PLL2 power bit is
cleared by accident.

Marking MX-64h as volatile in regmap solved the issue.

Signed-off-by: Ben Zhang <benzh@chromium.org>
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Link: https://lore.kernel.org/r/20191106011335.223061-6-cujomalainey@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/soc/codecs/rt5677.c