]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
jbd2: Fix possible overflow in jbd2_log_space_left()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2019 16:44:07 +0000 (17:44 +0100)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:27 +0000 (14:22 -0300)
commit32502f2df358723c11c5c461155417edd76c5dec
tree6add386965d938adfc42eae7af066ea5a0ae2aa2
parent650689170108a4f5e985ee102974291b28c4be95
jbd2: Fix possible overflow in jbd2_log_space_left()

BugLink: https://bugs.launchpad.net/bugs/1857158
commit add3efdd78b8a0478ce423bb9d4df6bd95e8b335 upstream.

When number of free space in the journal is very low, the arithmetic in
jbd2_log_space_left() could underflow resulting in very high number of
free blocks and thus triggering assertion failure in transaction commit
code complaining there's not enough space in the journal:

J_ASSERT(journal->j_free > 1);

Properly check for the low number of free blocks.

CC: stable@vger.kernel.org
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
include/linux/jbd2.h