]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
arm64: debug: Don't propagate UNKNOWN FAR into si_code for debug signals
authorWill Deacon <will.deacon@arm.com>
Fri, 1 Mar 2019 13:28:00 +0000 (13:28 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit325ad8cd2ec10f21da50be5d1e470c515bc141eb
treed3b06ee8ba0fe533817e39dc700c04c2b53d3dee
parent9cb89e915b58481f8a46ae68002a751a2e760bfb
arm64: debug: Don't propagate UNKNOWN FAR into si_code for debug signals

BugLink: https://bugs.launchpad.net/bugs/1838116
commit b9a4b9d084d978f80eb9210727c81804588b42ff upstream.

FAR_EL1 is UNKNOWN for all debug exceptions other than those caused by
taking a hardware watchpoint. Unfortunately, if a debug handler returns
a non-zero value, then we will propagate the UNKNOWN FAR value to
userspace via the si_addr field of the SIGTRAP siginfo_t.

Instead, let's set si_addr to take on the PC of the faulting instruction,
which we have available in the current pt_regs.

Cc: <stable@vger.kernel.org>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
arch/arm64/mm/fault.c