]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
batman-adv: fix multicast-via-unicast transmission with AP isolation
authorLinus Lüssing <linus.luessing@c0d3.blue>
Tue, 20 Mar 2018 02:13:27 +0000 (03:13 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commit359d2b4e35bae81ecdd3e790ea5d950aa3093c98
treea073e9c177e4f284ff66f15be23b580e5afaa591
parentf5389f4cf5dfd8176fd3f9794e0f395f7392098a
batman-adv: fix multicast-via-unicast transmission with AP isolation

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit f8fb3419ead44f9a3136995acd24e35da4525177 ]

For multicast frames AP isolation is only supposed to be checked on
the receiving nodes and never on the originating one.

Furthermore, the isolation or wifi flag bits should only be intepreted
as such for unicast and never multicast TT entries.

By injecting flags to the multicast TT entry claimed by a single
target node it was verified in tests that this multicast address
becomes unreachable, leading to packet loss.

Omitting the "src" parameter to the batadv_transtable_search() call
successfully skipped the AP isolation check and made the target
reachable again.

Fixes: 1d8ab8d3c176 ("batman-adv: Modified forwarding behaviour for multicast packets")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/batman-adv/multicast.c