]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
staging: speakup: fix tty-operation NULL derefs
authorJohan Hovold <johan@kernel.org>
Wed, 30 Jan 2019 09:49:34 +0000 (10:49 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit387e0393d4605087cb20d6c3aff22375649b582c
treecb466198afbccfa76ffd3fe3f45778418e95b46c
parent0903829d154bcc4bb7b2f5a43751e9abce53b52d
staging: speakup: fix tty-operation NULL derefs

BugLink: https://bugs.launchpad.net/bugs/1837664
commit a1960e0f1639cb1f7a3d94521760fc73091f6640 upstream.

The send_xchar() and tiocmset() tty operations are optional. Add the
missing sanity checks to prevent user-space triggerable NULL-pointer
dereferences.

Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
Cc: stable <stable@vger.kernel.org> # 4.13
Cc: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/staging/speakup/spk_ttyio.c