]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
dmaengine: rcar-dmac: Check the done lists in rcar_dmac_chan_get_residue()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fri, 2 Feb 2018 10:05:15 +0000 (19:05 +0900)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commit393d4d07979e7d1848a7ffdd3df0d76a2fc63e1a
tree3aa48d97790acfe7675289732b503c3d6c0ffd5d
parent681368c9cdcdd8e3be036858459a87ff71e479e2
dmaengine: rcar-dmac: Check the done lists in rcar_dmac_chan_get_residue()

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 3e081628d510b2ddbe493371d9c574d9275da17e ]

This patch fixes an issue that a race condition happens between a client
driver and the rcar-dmac driver:

- The rcar_dmac_isr_transfer_end() is called.
 - The done list appears, and desc.running is the next active list.
- rcar_dmac_chan_get_residue() is called by a client driver before
  rcar_dmac_isr_channel_thread() is called.
 - The rcar_dmac_chan_get_residue() will not find any descriptors.
 - And, the following WARNING happens:
WARN(1, "No descriptor for cookie!");

The sh-sci driver with HSCIF (921,600bps) on R-Car H3 can cause this
situation.
So, this patch checks the done lists in rcar_dmac_chan_get_residue()
and returns zero if the done lists has the argument cookie.

Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/dma/sh/rcar-dmac.c