]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: serial: mos7720: fix remote wakeup
authorJohan Hovold <johan@kernel.org>
Thu, 7 Nov 2019 13:21:18 +0000 (14:21 +0100)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:21:13 +0000 (14:21 -0300)
commit3ca6f50b332da48e89cb0de641e482e9a5bf9cb3
tree0788ba00c72cb6ae30f3399bfe2fb2969b72235e
parentbf718c3dfa27e219717d2cbd87b6cf8c703b24f5
USB: serial: mos7720: fix remote wakeup

BugLink: https://bugs.launchpad.net/bugs/1854975
commit ea422312a462696093b5db59d294439796cba4ad upstream.

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
Cc: stable <stable@vger.kernel.org> # 2.6.19
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/serial/mos7720.c