]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: chaoskey: fix use-after-free on release
authorJohan Hovold <johan@kernel.org>
Wed, 9 Oct 2019 15:38:45 +0000 (17:38 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:33 +0000 (19:04 +0100)
commit3d92066bf0afd58c2a2e99a619d71c2b3d45760a
treeb7ce97503f4b70ce49ef91f4399bf9bc612d7163
parentda052e093b21ae3b377c458ea6699958f918798e
USB: chaoskey: fix use-after-free on release

BugLink: https://bugs.launchpad.net/bugs/1850541
commit 93ddb1f56ae102f14f9e46a9a9c8017faa970003 upstream.

The driver was accessing its struct usb_interface in its release()
callback without holding a reference. This would lead to a
use-after-free whenever the device was disconnected while the character
device was still open.

Fixes: 66e3e591891d ("usb: Add driver for Altus Metrum ChaosKey device (v2)")
Cc: stable <stable@vger.kernel.org> # 4.1
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009153848.8664-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/misc/chaoskey.c