]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ftrace: Avoid potential division by zero in function profiler
authorWen Yang <wenyang@linux.alibaba.com>
Fri, 3 Jan 2020 03:02:48 +0000 (11:02 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:47:27 +0000 (23:47 -0500)
commit4462560e8908666c17c00c3ab4684c5e0998f1e8
treebd77f9400e4b6b4783cfb907fcc2e44eb6c155ec
parent9898ca0d9b5bd69e433868f52b78bf34f33366ce
ftrace: Avoid potential division by zero in function profiler

BugLink: https://bugs.launchpad.net/bugs/1860602
commit e31f7939c1c27faa5d0e3f14519eaf7c89e8a69d upstream.

The ftrace_profile->counter is unsigned long and
do_div truncates it to 32 bits, which means it can test
non-zero and be truncated to zero for division.
Fix this issue by using div64_ul() instead.

Link: http://lkml.kernel.org/r/20200103030248.14516-1-wenyang@linux.alibaba.com
Cc: stable@vger.kernel.org
Fixes: e330b3bcd8319 ("tracing: Show sample std dev in function profiling")
Fixes: 34886c8bc590f ("tracing: add average time in function to function profiler")
Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/trace/ftrace.c