]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mmc: sunxi: Filter out unsupported modes declared in the device tree
authorChen-Yu Tsai <wens@csie.org>
Tue, 5 Feb 2019 15:42:24 +0000 (23:42 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit4568243d6620b2bd70041b69a77faef33d017fa5
treeff0b63def80ca0a06ae677549716773b9d4d4223
parent176a038b68c48a7744996d219a67ae2579812604
mmc: sunxi: Filter out unsupported modes declared in the device tree

BugLink: https://bugs.launchpad.net/bugs/1837813
commit d6f11e7d91f2ac85f66194fe3ef8789b49901d64 upstream.

The MMC device tree bindings include properties used to signal various
signalling speed modes. Until now the sunxi driver was accepting them
without any further filtering, while the sunxi device trees were not
actually using them.

Since some of the H5 boards can not run at higher speed modes stably,
we are resorting to declaring the higher speed modes per-board.

Regardless, having boards declare modes and blindly following them,
even without proper support in the driver, is generally a bad thing.

Filter out all unsupported modes from the capabilities mask after
the device tree properties have been parsed.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/mmc/host/sunxi-mmc.c