]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
vhost: correctly check the return value of translate_desc() in log_used()
authorJason Wang <jasowang@redhat.com>
Tue, 19 Feb 2019 06:53:44 +0000 (14:53 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit515fa3a6774467493fa59c009131a4f517ac0970
tree87cdcaeffd87cf43cc61df46306d3388ae234be1
parentd2c78bc1b7743925e903e3f5f24b4bd5a6f8dcd4
vhost: correctly check the return value of translate_desc() in log_used()

BugLink: https://bugs.launchpad.net/bugs/1837813
[ Upstream commit 816db7663565cd23f74ed3d5c9240522e3fb0dda ]

When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.

Detected by CoverityScan, CID# 1442593:  Control flow issues  (DEADCODE)

Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/vhost/vhost.c