]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
fuse: Fix use-after-free in fuse_dev_do_read()
authorKirill Tkhai <ktkhai@virtuozzo.com>
Tue, 25 Sep 2018 09:28:55 +0000 (12:28 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 23 Apr 2019 15:51:47 +0000 (17:51 +0200)
commit54c318d5004af458616ac91b685d2408c184435d
tree75243b88cefc4633a5f36ed6de06e114b9ea195d
parent3b3caf8ef9a669e82b59a9a4fec63cc2dd9391e8
fuse: Fix use-after-free in fuse_dev_do_read()

BugLink: https://bugs.launchpad.net/bugs/1824553
We may pick freed req in this way:

[cpu0]                                  [cpu1]
fuse_dev_do_read()                      fuse_dev_do_write()
   list_move_tail(&req->list, ...);     ...
   spin_unlock(&fpq->lock);             ...
   ...                                  request_end(fc, req);
   ...                                    fuse_put_request(fc, req);
   if (test_bit(FR_INTERRUPTED, ...))
         queue_interrupt(fiq, req);

Fix that by keeping req alive until we finish all manipulations.

Reported-by: syzbot+4e975615ca01f2277bdd@syzkaller.appspotmail.com
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 46c34a348b0a ("fuse: no fc->lock for pqueue parts")
Cc: <stable@vger.kernel.org> # v4.2
(cherry picked from commit bc78abbd55dd28e2287ec6d6502b842321a17c87)
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
fs/fuse/dev.c