]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
bridge: check brport attr show in brport_show
authorXin Long <lucien.xin@gmail.com>
Mon, 12 Feb 2018 09:15:40 +0000 (17:15 +0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 15 Mar 2018 13:27:48 +0000 (08:27 -0500)
commit55d369c709b893629b9b1d62d3cc90f7a128aab4
treea44b90a3926ec82b39d9f50dfc070862c5124e5d
parent8ef0c2516121349e928de1a4b5f2a04a49d6b5ac
bridge: check brport attr show in brport_show

BugLink: http://bugs.launchpad.net/bugs/1755179
[ Upstream commit 1b12580af1d0677c3c3a19e35bfe5d59b03f737f ]

Now br_sysfs_if file flush doesn't have attr show. To read it will
cause kernel panic after users chmod u+r this file.

Xiong found this issue when running the commands:

  ip link add br0 type bridge
  ip link add type veth
  ip link set veth0 master br0
  chmod u+r /sys/devices/virtual/net/veth0/brport/flush
  timeout 3 cat /sys/devices/virtual/net/veth0/brport/flush

kernel crashed with NULL a pointer dereference call trace.

This patch is to fix it by return -EINVAL when brport_attr->show
is null, just the same as the check for brport_attr->store in
brport_store().

Fixes: 9cf637473c85 ("bridge: add sysfs hook to flush forwarding table")
Reported-by: Xiong Zhou <xzhou@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
net/bridge/br_sysfs_if.c