]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
Revert "net/ibm/emac: wrong bit is used for STA control"
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 7 Dec 2018 04:05:04 +0000 (15:05 +1100)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:45:10 +0000 (09:45 -0600)
commit5c6a72f6f83b5d3646dd41f665d864ce64881232
tree365b3006a5628089c8c769813e4248660b8d166e
parent118c45bee32e6b48b5872d0dda0ebfe2ae085e23
Revert "net/ibm/emac: wrong bit is used for STA control"

BugLink: https://bugs.launchpad.net/bugs/1837161
[ Upstream commit 5b3279e2cba2238b37f6c18adfdea8bddb32715a ]

This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9.

This commit is completely bogus. The STACR register has two formats, old
and new, depending on the version of the IP block used. There's a pair of
device-tree properties that can be used to specify the format used:

has-inverted-stacr-oc
has-new-stacr-staopc

What this commit did was to change the bit definition used with the old
parts to match the new parts. This of course breaks the driver on all
the old ones.

Instead, the author should have set the appropriate properties in the
device-tree for the variant used on his board.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/ibm/emac/emac.h