]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: v4l2-ctrls.c/uvc: zero v4l2_event
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 18 Dec 2018 13:37:08 +0000 (08:37 -0500)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit654380580e7fa9c62b259ab52ebba2f4741fee8d
treebf0b6df5c7ce8c5753e0e2991b00ca5edc4a742d
parentf67bb8863f5b95a65f059cbb24306ce44c709103
media: v4l2-ctrls.c/uvc: zero v4l2_event

BugLink: https://bugs.launchpad.net/bugs/1838116
commit f45f3f753b0a3d739acda8e311b4f744d82dc52a upstream.

Control events can leak kernel memory since they do not fully zero the
event. The same code is present in both v4l2-ctrls.c and uvc_ctrl.c, so
fix both.

It appears that all other event code is properly zeroing the structure,
it's these two places.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: syzbot+4f021cf3697781dbd9fb@syzkaller.appspotmail.com
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/media/usb/uvc/uvc_ctrl.c
drivers/media/v4l2-core/v4l2-ctrls.c