]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: serpent - mark __serpent_setkey_sbox noinline
authorArnd Bergmann <arnd@arndb.de>
Tue, 18 Jun 2019 11:19:42 +0000 (13:19 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit669dead33eac5a376b05b03e6d10413664d10cdf
tree4041fa69e6dc2e5ca0135c33d377a6fd6c499b90
parentfe1d2585721937a695a9b164f1fda1121fcac954
crypto: serpent - mark __serpent_setkey_sbox noinline

BugLink: https://bugs.launchpad.net/bugs/1839036
[ Upstream commit 473971187d6727609951858c63bf12b0307ef015 ]

The same bug that gcc hit in the past is apparently now showing
up with clang, which decides to inline __serpent_setkey_sbox:

crypto/serpent_generic.c:268:5: error: stack frame size of 2112 bytes in function '__serpent_setkey' [-Werror,-Wframe-larger-than=]

Marking it 'noinline' reduces the stack usage from 2112 bytes to
192 and 96 bytes, respectively, and seems to generate more
useful object code.

Fixes: c871c10e4ea7 ("crypto: serpent - improve __serpent_setkey with UBSAN")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
crypto/serpent_generic.c