]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
[SCSI] pm8001: missing break statements
authorMark Salyzyn <mark_salyzyn@us.xyratex.com>
Mon, 26 Sep 2011 14:57:36 +0000 (07:57 -0700)
committerJames Bottomley <JBottomley@Parallels.com>
Sun, 2 Oct 2011 18:05:11 +0000 (13:05 -0500)
commit6fbc769219a7a8060ea33f397304f05b1cdf8a00
tree31751b6a4996e2caaccb96c855b783f9f5a89b28
parentb90b378ad5767c0743113c675b09ac00fa534c33
[SCSI] pm8001: missing break statements

Code Inspection: found two missing break directives. First one will
result in not retrying an a task that report
IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY, the second will result in cosmetic
debug printk conflicting statement stutter. Because checkpatch.pl came
up with a warning regarding unnecessary space before a newline on one of
the fragments associated with the diff context, I took the liberty of
fixing all the cases of this issue in the pair of files touched by this
defect. These cosmetic changes hide the break changes :-(

To help focus, break changes are in pm8001_hwi.c fragment line 1649 for
the IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY case statement and pm8001_sas.c
line 1000 deals with the conflicting debug print stutter.

Signed-off-by: Mark Salyzyn <mark_salyzyn@us.xyratex.com>
Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/pm8001/pm8001_hwi.c
drivers/scsi/pm8001/pm8001_sas.c