]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
virtio-net: serialize tx routine during reset
authorJason Wang <jasowang@redhat.com>
Wed, 28 Jun 2017 01:51:03 +0000 (09:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Jun 2017 16:51:59 +0000 (12:51 -0400)
commit713a98d90c5ea072c1bb00ef40617aee2cef2232
treedb93479ad5f5a93653fd59862d45744d7472ed12
parente20bd60bf62a2448be873653c7febca1d4d73afc
virtio-net: serialize tx routine during reset

We don't hold any tx lock when trying to disable TX during reset, this
would lead a use after free since ndo_start_xmit() tries to access
the virtqueue which has already been freed. Fix this by using
netif_tx_disable() before freeing the vqs, this could make sure no tx
after vq freeing.

Reported-by: Jean-Philippe Menil <jpmenil@gmail.com>
Tested-by: Jean-Philippe Menil <jpmenil@gmail.com>
Fixes commit f600b6905015 ("virtio_net: Add XDP support")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Robert McCabe <robert.mccabe@rockwellcollins.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c