]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Mon, 20 Nov 2017 14:12:29 +0000 (08:12 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Nov 2017 04:00:44 +0000 (23:00 -0500)
commit727535903bea924c4f73abb202c4b3e85fff0ca4
treef68d4b8d2400105cf78abad963b894bf7e59eff5
parente4717292ddebcfe231651b5aff9fa19ca158d178
scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg

_vreg_ is being dereferenced before it is null checked, hence there is a
potential null pointer dereference.

Fix this by moving the pointer dereference after _vreg_ has been null
checked.

This issue was detected with the help of Coccinelle.

Fixes: aa4976130934 ("ufs: Add regulator enable support")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c