]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
vhost: correctly remove wait queue during poll failure
authorJason Wang <jasowang@redhat.com>
Tue, 27 Mar 2018 12:50:52 +0000 (20:50 +0800)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 12 Apr 2018 13:06:47 +0000 (10:06 -0300)
commit76a163f28e2cc4bdc3985c39a6325b0bea202ab0
treee63bea41807559f88a1e2fc50c04c4d75a8c41a3
parent7d3718d454bf3ac853d68eef318e049e1e19d69d
vhost: correctly remove wait queue during poll failure

BugLink: http://bugs.launchpad.net/bugs/1763366
[ Upstream commit dc6455a71c7fc5117977e197f67f71b49f27baba ]

We tried to remove vq poll from wait queue, but do not check whether
or not it was in a list before. This will lead double free. Fixing
this by switching to use vhost_poll_stop() which zeros poll->wqh after
removing poll from waitqueue to make sure it won't be freed twice.

Cc: Darren Kenny <darren.kenny@oracle.com>
Reported-by: syzbot+c0272972b01b872e604a@syzkaller.appspotmail.com
Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/vhost/vhost.c