]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
block/bio-integrity: fix a memory leak bug
authorWenwen Wang <wenwen@cs.uga.edu>
Thu, 11 Jul 2019 19:22:02 +0000 (14:22 -0500)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit78b43e5f53b75d3046bfb32f8b23c94995a4060a
tree52f12fdd0817beee71388b03b2dfe789b27440b4
parent873e28bfa9bef6ce7f92bc373c3895dae007c41a
block/bio-integrity: fix a memory leak bug

BugLink: https://bugs.launchpad.net/bugs/1839036
[ Upstream commit e7bf90e5afe3aa1d1282c1635a49e17a32c4ecec ]

In bio_integrity_prep(), a kernel buffer is allocated through kmalloc() to
hold integrity metadata. Later on, the buffer will be attached to the bio
structure through bio_integrity_add_page(), which returns the number of
bytes of integrity metadata attached. Due to unexpected situations,
bio_integrity_add_page() may return 0. As a result, bio_integrity_prep()
needs to be terminated with 'false' returned to indicate this error.
However, the allocated kernel buffer is not freed on this execution path,
leading to a memory leak.

To fix this issue, free the allocated buffer before returning from
bio_integrity_prep().

Reviewed-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
block/bio-integrity.c