]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: legousbtower: fix open after failed reset request
authorJohan Hovold <johan@kernel.org>
Thu, 19 Sep 2019 08:30:39 +0000 (10:30 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:35 +0000 (19:04 +0100)
commit7c89355287d774bd013ecaf48bf7f5c8af794c56
tree9044b8160a9978d05ee6ad258bd01374f12b2660
parent94309318a812adbfefc3a522670f5387574c26cc
USB: legousbtower: fix open after failed reset request

BugLink: https://bugs.launchpad.net/bugs/1850541
commit 0b074f6986751361ff442bc1127c1648567aa8d6 upstream.

The driver would return with a nonzero open count in case the reset
control request failed. This would prevent any further attempts to open
the char dev until the device was disconnected.

Fix this by incrementing the open count only on successful open.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190919083039.30898-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/misc/legousbtower.c