]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
HID: wacom: generic: read HID_DG_CONTACTMAX from any feature report
authorAaron Armstrong Skomra <skomra@gmail.com>
Wed, 12 Jun 2019 21:19:29 +0000 (14:19 -0700)
committerKhalid Elmously <khalid.elmously@canonical.com>
Thu, 26 Sep 2019 04:34:52 +0000 (00:34 -0400)
commit7fb480941900f01a92f9fedb9f07199e449a5c5e
treee33efd6c6d39aabdf765ad4bd7a3f15528d40c3c
parent2b897a379b1f11ac536318a28fcf249ff720619d
HID: wacom: generic: read HID_DG_CONTACTMAX from any feature report

BugLink: https://bugs.launchpad.net/bugs/1845266
commit 184eccd40389df29abefab88092c4ff33191fd0c upstream.

In the generic code path, HID_DG_CONTACTMAX was previously
only read from the second byte of report 0x23.

Another report (0x82) has the HID_DG_CONTACTMAX in the
higher nibble of the third byte. We should support reading the
value of HID_DG_CONTACTMAX no matter what report we are reading
or which position that value is in.

To do this we submit the feature report as a event report
using hid_report_raw_event(). Our modified finger event path
records the value of HID_DG_CONTACTMAX when it sees that usage.

Fixes: 8ffffd5212846 ("HID: wacom: fix timeout on probe for some wacoms")
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/hid/wacom_sys.c
drivers/hid/wacom_wac.c