]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
btrfs: Remove false alert when fiemap range is smaller than on-disk extent
authorQu Wenruo <quwenruo@cn.fujitsu.com>
Thu, 22 Jun 2017 02:01:21 +0000 (10:01 +0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 29 Jun 2017 18:25:20 +0000 (20:25 +0200)
commit848c23b78fafdcd3270b06a30737f8dbd70c347f
tree21a9247ef8e9070e818e62bb0e47ae4c08ecfc1f
parentb7f8a09f8097db776b8d160862540e4fc1f51296
btrfs: Remove false alert when fiemap range is smaller than on-disk extent

Commit 4751832da990 ("btrfs: fiemap: Cache and merge fiemap extent before
submit it to user") introduced a warning to catch unemitted cached
fiemap extent.

However such warning doesn't take the following case into consideration:

0 4K 8K
|<---- fiemap range --->|
|<----------- On-disk extent ------------------>|

In this case, the whole 0~8K is cached, and since it's larger than
fiemap range, it break the fiemap extent emit loop.
This leaves the fiemap extent cached but not emitted, and caught by the
final fiemap extent sanity check, causing kernel warning.

This patch removes the kernel warning and renames the sanity check to
emit_last_fiemap_cache() since it's possible and valid to have cached
fiemap extent.

Reported-by: David Sterba <dsterba@suse.cz>
Reported-by: Adam Borowski <kilobyte@angband.pl>
Fixes: 4751832da990 ("btrfs: fiemap: Cache and merge fiemap extent ...")
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c