]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: uvcvideo: Fix uvc_alloc_entity() allocation alignment
authorNadav Amit <namit@vmware.com>
Mon, 4 Jun 2018 13:47:13 +0000 (09:47 -0400)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit8f172dc9b8b1de3dd3c186956cfa18360688b79e
treec8f272b80932f38b08b02919b3b4f34e68d6ee98
parent270e158669337ad3f36cae8c2ac8c6b659955923
media: uvcvideo: Fix uvc_alloc_entity() allocation alignment

BugLink: https://bugs.launchpad.net/bugs/1838700
commit 89dd34caf73e28018c58cd193751e41b1f8bdc56 upstream.

The use of ALIGN() in uvc_alloc_entity() is incorrect, since the size of
(entity->pads) is not a power of two. As a stop-gap, until a better
solution is adapted, use roundup() instead.

Found by a static assertion. Compile-tested only.

Fixes: 4ffc2d89f38a ("uvcvideo: Register subdevices for each entity")
Signed-off-by: Nadav Amit <namit@vmware.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/media/usb/uvc/uvc_driver.c