]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mailbox: xgene-slimpro: Fix potential NULL pointer dereference
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 26 Jul 2018 17:11:39 +0000 (12:11 -0500)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:45:34 +0000 (19:45 -0600)
commit91573c121322bc6f27fb233c879d02931ff7582c
treebfa8cd9142d62bbdb2b0fef76f1b973a8e875ef6
parent198b51d11930a67bb3d3b66abaf3155da3a7609b
mailbox: xgene-slimpro: Fix potential NULL pointer dereference

BugLink: https://bugs.launchpad.net/bugs/1835972
commit 3512a18cbd8d09e22a790540cb9624c3c49827ba upstream.

There is a potential execution path in which function
platform_get_resource() returns NULL. If this happens,
we will end up having a NULL pointer dereference.

Fix this by replacing devm_ioremap with devm_ioremap_resource,
which has the NULL check and the memory region request.

This code was detected with the help of Coccinelle.

Cc: stable@vger.kernel.org
Fixes: f700e84f417b ("mailbox: Add support for APM X-Gene platform mailbox driver")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/mailbox/mailbox-xgene-slimpro.c