]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
HID: sony: Fix memory corruption issue on cleanup.
authorRoderick Colenbrander <roderick.colenbrander@sony.com>
Wed, 4 Sep 2019 21:22:11 +0000 (14:22 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 16 Oct 2019 09:55:13 +0000 (11:55 +0200)
commit92a79917406e1b57260d3b3ccd0eda77b7f023d1
tree345c1f9e37f2b892e59aeab34b1bda3d1bc0cdee
parent41f27c249a54f779eef88d83bcce000f7e884be6
HID: sony: Fix memory corruption issue on cleanup.

BugLink: https://bugs.launchpad.net/bugs/1847155
commit 2bcdacb70327013ca2066bfcf2af1009eff01f1d upstream.

The sony driver is not properly cleaning up from potential failures in
sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
is still running. This is not a good idea, instead hid_hw_stop should
be moved to sony_probe. Similar changes were recently made to Logitech
drivers, which were also doing improper cleanup.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
CC: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/hid/hid-sony.c